[MPlayer-dev-eng] [PATCH] Apple Remote support

[Ulion]

2007/8/12, Diego Biurrun <diego at biurrun.de>:
> > +  // If search is unsuccessful, return no-zero
>
> non-zero
>
> > +        if(!CFNumberGetValue((CFNumberRef) object, kCFNumberLongType, &number))
>
> Please add a space after the if here.
>
> ...
>
> Add a period at the end of the sentence, same for the other
> translations.
>
> Also, please try to avoid trailing whitespace.
>
> Fix these issues and the patch is OK from my side.
>
> Diego

all fixed



2007/8/13, Alban Bedel <albeu at free.fr>:
> On Sun, 12 Aug 2007 02:29:11 -0400
> "? ?" <ulion2002 at msn.com> wrote:
>
> > +#ifdef HAVE_APPLE_REMOTE
> > +  if(use_ar) {
> > +    if(mp_input_ar_init() < 0)
> > +      mp_msg
> > (MSGT_INPUT,MSGL_ERR,MSGTR_INPUT_INPUT_ErrCantInitAppleRemote);
> > +    else
> > +      mp_input_add_key_fd(MP_MAX_KEY_FD - 1,0,mp_input_ar_read,mp_input_ar_close);
> > +  }
> > +#endif
> > +
>
> You should use an invalid value (-1) for the fd when there is no real
> fd. Otherwise the patch look good.
>
>         Albeu
yes, (-1) will work fine, fixed.

here is the fixed patch.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apple_remote_all_fixed.patch
Type: application/octet-stream
Size: 26663 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070813/c67f4228/attachment.obj>