[MPlayer-dev-eng] [PATCH] Apple Remote support

[Diego Biurrun]

On Sun, Aug 12, 2007 at 02:29:11AM -0400, ? ? wrote:
>
> I found last modified code does not work properly when mplayer is in slave 
> mode, so I fixed it, here is the newest patch.
>
> --- configure	(revision 24045)
> +++ configure	(working copy)
> @@ -3571,6 +3575,42 @@
> +
> +  // If search is unsuccessful, return no-zero

non-zero

> --- input/ar.c	(revision 0)
> +++ input/ar.c	(revision 0)
> @@ -0,0 +1,356 @@
> +        if (object == 0 || CFGetTypeID(object) != CFNumberGetTypeID())
> +            continue;
> +        if(!CFNumberGetValue((CFNumberRef) object, kCFNumberLongType, &number))

Please add a space after the if here.

> +    else if (!hidDeviceIsOpen) {
> +        if( kIOReturnSuccess == (*hidDeviceInterface)->open(hidDeviceInterface, kIOHIDOptionsTypeSeizeDevice) )

ditto

> --- input/ar.h	(revision 0)
> +++ input/ar.h	(revision 0)
> @@ -0,0 +1,43 @@
> + 
> +#ifndef __INPUT_AR_H_
> +#define __INPUT_AR_H_

Names with leading underscores are reserved for the system

> +#define AR_BASE	     0x500

tabs

> +#endif

#endif /* INPUT_AR_H */

> --- input/Makefile	(revision 24045)
> +++ input/Makefile	(working copy)
> @@ -5,5 +5,6 @@
>  SRCS_MPLAYER              = input.c
>  SRCS_MPLAYER-$(JOYSTICK) += joystick.c
>  SRCS_MPLAYER-$(LIRC)     += lirc.c
> +SRCS_MPLAYER-$(APPLE_REMOTE) += ar.c

alphabetical order

> --- help/help_mp-es.h	(revision 24045)
> +++ help/help_mp-es.h	(working copy)
> @@ -1289,6 +1289,7 @@
>  #define MSGTR_INPUT_INPUT_ErrCantOpenFile "No se puede abrir %s: %s\n"
> +#define MSGTR_INPUT_INPUT_ErrCantInitAppleRemote "No se puede inicializar la entrada del Apple Remote\n"

Add a period at the end of the sentence, same for the other
translations.

Also, please try to avoid trailing whitespace.

Fix these issues and the patch is OK from my side.

Diego