[MPlayer-dev-eng] [PATCH] af_ambisonic

Rich Felker dalias at aerifal.cx
Wed Apr 18 07:06:12 CEST 2007


On Wed, Apr 18, 2007 at 12:47:42AM -0400, Compn wrote:
> On Wed, 18 Apr 2007 05:55:04 +0200, Sebastian Olter scribed:
> 
> >+#if defined(_WIN32) && !defined (__CYGWIN__)
> >+static char* strsep(char** haystack, char *needle)
> 
> what does this do? 

strsep is a common but nonstandardized function. apparently this is
making up for is being present on the system but missing in the
headers. however it should just not be used..

> >Index: libmpdemux/extension.c
> >===================================================================
> >--- libmpdemux/extension.c	(revision 23012)
> >+++ libmpdemux/extension.c	(working copy)
> >@@ -36,6 +36,7 @@
> >         { "y4m", DEMUXER_TYPE_Y4M },
> >         { "mp3", DEMUXER_TYPE_AUDIO },
> >         { "wav", DEMUXER_TYPE_AUDIO },
> >+        { "amb", DEMUXER_TYPE_AUDIO },
> >         { "flac", DEMUXER_TYPE_AUDIO },
> >         { "fla", DEMUXER_TYPE_AUDIO },
> >         { "ogg", DEMUXER_TYPE_OGG },
> 
> does the mplayer detection try a wrong demuxer for amb files?
> 
> otherwise, this looks interesting... new filters are always welcome.

indeed. it would be nice to see more documentation/facts and less
hype, but the basic idea is quite sound. 5.1 is and always has been
stupid.

rich



More information about the MPlayer-dev-eng mailing list