[MPlayer-dev-eng] Re: [PATCH] af_ambisonic

[Sebastian Olter]

2007/4/18, compn <tempn at twmi.rr.com>
>> +#if defined(_WIN32) && !defined (__CYGWIN__)
>> +static char* strsep(char** haystack, char *needle)
> what does this do?

It was actually a surprise to see there is no strsep(3) in mingw, so I
reimplemented it.

> this part should probably go into the manpage instead...

Ok. I moved the help to a DOCS/tech document; such a document is
necessary anyway so
it is a good starting point.

> does the mplayer detection try a wrong demuxer for amb files?

They are wav files; MPlayer tries to parse some of them as mpeg.

2007/4/18, *Rich Felker* <dalias at aerifal.cx>
<mplayer-dev-eng%40mplayerhq.hu?Subject=%5BMPlayer-dev-eng%5D%20%5BPATCH%5D%20af_ambisonic&In-Reply-To=20070418004742.f4588361.tempn%40twmi.rr.com>
> strsep is a common but nonstandardized function. apparently this is
> making up for is being present on the system but missing in the
> headers. however it should just not be used..

Mingw refuses to link this function. Cygwin instead, has a strsep()
that works the
same way as mine. I used Macintosh documentation ("man strsep" in
firefox results in
hmug.org) to write it. Strsep is simpler and thus safer than other
such functions; the
question is not whether to use it, but rather how to maintain
portability with it. I
removed the ifdef and renamed the function to str_sep().

> it would be nice to see more documentation/facts and less hype

Ambisonics derives from math, it hasn't any de jure standard except
file formats
(there were some patents but they expired many years ago). There is plenty of
documentation in internet, and its community consists of people having
different
points of view (for example: scientists vs. content creators). Try to
google for
'ambisonic'. You may be disappointed by the amount of existing
software--my filter is
one of the first freely available decoders.

An updated patch is in attachment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ambisonic.patch
Type: application/octet-stream
Size: 18928 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070418/182c58d7/attachment.obj>