[MPlayer-dev-eng] [PATCH] af_ambisonic

[Compn]

On Wed, 18 Apr 2007 05:55:04 +0200, Sebastian Olter scribed:

>+#if defined(_WIN32) && !defined (__CYGWIN__)
>+static char* strsep(char** haystack, char *needle)

what does this do? 

>+            af_msg(AF_MSG_ERROR,
>+                   "[af_ambisonic] Unknown option: %s\n"
>+                   "Usage:\n\n"
>+                   "-af amb[=params]\n\n"
>+                   "Params:\n"

this part should probably go into the manpage instead...


>Index: libmpdemux/extension.c
>===================================================================
>--- libmpdemux/extension.c	(revision 23012)
>+++ libmpdemux/extension.c	(working copy)
>@@ -36,6 +36,7 @@
>         { "y4m", DEMUXER_TYPE_Y4M },
>         { "mp3", DEMUXER_TYPE_AUDIO },
>         { "wav", DEMUXER_TYPE_AUDIO },
>+        { "amb", DEMUXER_TYPE_AUDIO },
>         { "flac", DEMUXER_TYPE_AUDIO },
>         { "fla", DEMUXER_TYPE_AUDIO },
>         { "ogg", DEMUXER_TYPE_OGG },

does the mplayer detection try a wrong demuxer for amb files?

otherwise, this looks interesting... new filters are always welcome.

-compn