[MPlayer-dev-eng] [PATCH] dvdnav part 3

[Nico Sabbi]

Ötvös Attila wrote:

>szerda 22 november 2006 10:24 dátummal Diego Biurrun ezt írta:
>  
>
>>I just had a very quick look, so I can only comment on formalities that
>>caught my eye:
>>
>>- Please don't compress tiny patches, it just makes them bothersome to
>>  handle and reviews less likely.
>>- Nit: Please don't add trailing whitespace.
>>- Please don't mix spaces and tabs for indentation.
>>- Please respect surrounding indentation, i.e. don't indent by two
>>  spaces when most of the code in mplayer.c is indented by four.
>>
>>Other than that it would help if you could split your patches into small
>>self-contained parts.
>>    
>>
>
>I corrected and separated.
>
>Comment?
>
>Best regards.
>Attila
>  
>
>  
>
just a very quick look:

>+#define VDCTRL_SET_CODEC_FLAG_LOW_DELAY 10 /* set/reset codec flag low delay */
>  
>

this

> 
>+
>+void vd_set_codec_flag_low_delay(sh_video_t *sh_video, int mode) {
>+if (mpvdec)
>+    mpvdec->control(sh_video,VDCTRL_SET_CODEC_FLAG_LOW_DELAY, (void*)(&mode));
>+return;
>+}
>  
>

and this should not be necessary. I found the proper patch for lavc; 
I'll test it tonight
if it works as expected.
Can someone give a look at Attila's SPU code, please?