[MPlayer-dev-eng] [PATCH] dvdnav part 3

[Diego Biurrun]

On Wed, Nov 22, 2006 at 02:59:48PM +0100, Ötvös Attila wrote:
> szerda 22 november 2006 10:24 dátummal Diego Biurrun ezt írta:
> > I just had a very quick look, so I can only comment on formalities that
> > caught my eye:
> >
> > - Please don't compress tiny patches, it just makes them bothersome to
> >   handle and reviews less likely.
> > - Nit: Please don't add trailing whitespace.
> > - Please don't mix spaces and tabs for indentation.
> > - Please respect surrounding indentation, i.e. don't indent by two
> >   spaces when most of the code in mplayer.c is indented by four.
> >
> > Other than that it would help if you could split your patches into small
> > self-contained parts.
> 
> I corrected and separated.
> 
> Comment?

Another formality: Please don't indent by 3 characters.

Diego