[MPlayer-dev-eng] [PATCH] dvdnav part 3

[Ötvös Attila]

szerda 22 november 2006 10:24 dátummal Diego Biurrun ezt írta:
> I just had a very quick look, so I can only comment on formalities that
> caught my eye:
>
> - Please don't compress tiny patches, it just makes them bothersome to
>   handle and reviews less likely.
> - Nit: Please don't add trailing whitespace.
> - Please don't mix spaces and tabs for indentation.
> - Please respect surrounding indentation, i.e. don't indent by two
>   spaces when most of the code in mplayer.c is indented by four.
>
> Other than that it would help if you could split your patches into small
> self-contained parts.

I corrected and separated.

Comment?

Best regards.
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3-simple_box.patch
Type: text/x-diff
Size: 2575 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1-low_delay.patch
Type: text/x-diff
Size: 1185 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5-audio_id.patch
Type: text/x-diff
Size: 1872 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7-color_spu.patch
Type: text/x-diff
Size: 3624 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6-spu.patch
Type: text/x-diff
Size: 3651 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4-still_wait.patch
Type: text/x-diff
Size: 16822 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2-low_delay.patch
Type: text/x-diff
Size: 1389 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061122/5ec64d82/attachment-0006.patch>