[MPlayer-dev-eng] [PATCH] dvdnav part 3

Diego Biurrun diego at biurrun.de
Wed Nov 22 10:24:23 CET 2006


On Wed, Nov 22, 2006 at 01:25:32AM +0100, Ötvös Attila wrote:
> 
> comment?

I just had a very quick look, so I can only comment on formalities that
caught my eye:

- Please don't compress tiny patches, it just makes them bothersome to
  handle and reviews less likely.
- Nit: Please don't add trailing whitespace.
- Please don't mix spaces and tabs for indentation.
- Please respect surrounding indentation, i.e. don't indent by two
  spaces when most of the code in mplayer.c is indented by four.

Other than that it would help if you could split your patches into small
self-contained parts.

Diego



More information about the MPlayer-dev-eng mailing list