[MPlayer-dev-eng] [PATCH] new pvr demuxer support

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Jul 8 16:03:05 CEST 2006


On Sat, 2006-07-08 at 15:57 +0200, Diego Biurrun wrote:
> On Sat, Jul 08, 2006 at 03:47:09PM +0200, Benjamin Zores wrote:
> > No, it was meant for purpose.
> > As you see below this line, no cc_check is done (already done when testing v4l2 support).
> > So if you --enable-pvr but there's no v4l2 support then compilation will fail.
> > That's why the test is needed for both cases.
> 
> I'm aware of this.  Compilation may fail if you fiddle with --enable
> options to configure.  Don't second-guess the user.  Look at the other
> tests, they have similar semantics.  So please just run the test in auto
> mode.

Although his explanation was a bit unclear I think his argument makes
sense. His code does not "run tests" at all, it only checks that the
variables used in configure are internally consistent. I don't think
that counts as "secound-guessing the user".




More information about the MPlayer-dev-eng mailing list