[MPlayer-dev-eng] [PATCH] new pvr demuxer support

Diego Biurrun diego at biurrun.de
Sat Jul 8 15:57:46 CEST 2006


On Sat, Jul 08, 2006 at 03:47:09PM +0200, Benjamin Zores wrote:
> On Sat, 8 Jul 2006 15:25:37 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sat, Jul 08, 2006 at 01:53:05PM +0200, Benjamin Zores wrote:
> > > 
> > > --- configure	(r??vision 18944)
> > > +++ configure	(copie de travail)
> > > @@ -6791,6 +6795,23 @@
> > >  
> > > +echocheck "Video 4 Linux 2/IVTV PVR interface"
> > > +if test "$_pvr" = auto -o "$_pvr" = yes; then
> > 
> > Only run this test if _pvr is set to auto.
> 
> No, it was meant for purpose.
> As you see below this line, no cc_check is done (already done when testing v4l2 support).
> So if you --enable-pvr but there's no v4l2 support then compilation will fail.
> That's why the test is needed for both cases.

I'm aware of this.  Compilation may fail if you fiddle with --enable
options to configure.  Don't second-guess the user.  Look at the other
tests, they have similar semantics.  So please just run the test in auto
mode.

Diego



More information about the MPlayer-dev-eng mailing list