[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Sunday 25 June 2006 18:02, Uoti Urpala wrote:
> IMO handling a separate patch for this is much more trouble than
> including it in the main patch (yes I know some people asked to have it
> separately...).

It seems that the multipatch version will satisfy more people. However, it is 
just my perception. We should probably put it to the vote.

> +               images = ass_render_frame(vf->priv->ass_priv, ass_track,
> (pts+sub_delay) * 1000);
>
> It would be better to round the timestamp value instead of the current
> truncating cast to long long. [...]

Fixed.

The patches are starting to multiply, there is now 6 of them.

1. shsubt.patch
Moves mkv_sh_sub_t to demuxer.h and renames it to sh_sub_t.

2. utf8_get_char.patch
Makes utf8_get_char() non-static. It is used in libass.

3. guess_cp.patch
Splits guess_cp() in two functions:
- guess_buffer_cp() determines the encoding of text, given a pointer to a 
buffer and its length;
- guess_cp() reads some data from stream and calls guess_buffer_cp()
guess_buffer_cp() is used in libass.

4. mplayer-ass.patch
Everything else is here.

5. cosmetics.patch

6. mencoder-ass.patch

Man page is updated, some minor bugs fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cosmetics.patch
Type: text/x-diff
Size: 491 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shsubt.patch
Type: text/x-diff
Size: 3830 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utf8_get_char.patch
Type: text/x-diff
Size: 611 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: guess_cp.patch
Type: text/x-diff
Size: 2268 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mencoder-ass.patch
Type: text/x-diff
Size: 3712 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-ass.patch.bz2
Type: application/x-bzip2
Size: 31856 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060703/fccfadb7/attachment.bin>