[MPlayer-dev-eng] [PATCH] Optimize vo_macosx

Tim Wojtulewicz timwoj at ieee.org
Mon Jul 3 19:26:34 CEST 2006


On Jul 3, 2006, at 4:03 AM, Nicolas Plourde wrote:

>
> On 2-Jul-06, at 3:23 PM, Alexander Strange wrote:
>
>> This patch simply removes the memcpy calls on the picture data in  
>> vo_macosx, making it 2x faster.
>> As a side effect, it also disables the OSD rendering; I removed  
>> that code and VFCAP_OSD, but that means this depends on the other  
>> patch (mentioned in a previous thread) that automatically inserts - 
>> vf expand=::::1. If you try it now, it should work normally but  
>> you'll have to put that filter in by hand.
>>
>> The old memcpy path still exists (minus the actual OSD drawing) in  
>> the shared_buffer case, because I don't know what that does and  
>> can't test it.
>>
>> By the way, is it guaranteed that the picture data will always  
>> have the same pointer? That would simplify this.
>> <vo-macosx-optim.patch>
>>
>
> Im going to test it tonight. The shared_buffer path is for  
> mplayerosx btw.

I looked at it briefly yesterday and didn't see much improvement over  
the prior code on this g4.  It didn't apply cleanly to the latest svn  
also.  I might look at it again today if I get a chance.

Tim




More information about the MPlayer-dev-eng mailing list