[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Dominik 'Rathann' Mierzejewski]

On Sunday, 02 July 2006 at 22:42, Evgeniy Stepanov wrote:
> The patches are starting to multiply, there is now 6 of them.

Don't worry, that's what makes them easier to apply separately.

> 1. shsubt.patch
> Moves mkv_sh_sub_t to demuxer.h and renames it to sh_sub_t.
> 2. utf8_get_char.patch
> Makes utf8_get_char() non-static. It is used in libass.
> 3. guess_cp.patch
> Splits guess_cp() in two functions:
> - guess_buffer_cp() determines the encoding of text, given a pointer to a 
> buffer and its length;
> - guess_cp() reads some data from stream and calls guess_buffer_cp()
> guess_buffer_cp() is used in libass.
> 4. mplayer-ass.patch
> Everything else is here.
> 5. cosmetics.patch

I've been using this patch for a while now with little or no problems at
all, so I'm going to apply 1-5 soon if nobody objects. Hopefully after
some comments from Moritz on demux_mkv changes.

> 6. mencoder-ass.patch

Apparently this doesn't work well. It's not this patch's fault but rather
general mencoder pts mishandling. I'll probably apply this after that is
fixed.

> Man page is updated, some minor bugs fixed.

Great.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan