[MPlayer-dev-eng] [PATCH] libvo/aclib_template.c small_memcpy wrong??

Ivan Kalvachev ikalvachev at gmail.com
Mon Feb 20 13:52:50 CET 2006


2005/12/5, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hi,
> here is an untested patch for $SUBJECT, which I think is broken. What is
> that dummy variable supposed to be? It is never initialized. Also
> without cld the copy might go off in the wrong direction and cause a
> segfault.

Read the comment, this variable is not input one, but output. This
means that the ECX will be stored in it. The point is we don't want to
waste time for storing it. On the other side the delta var is also
temporal...

Anyway the best way to check this is to see what different compilers
generate. (gcc -S)




More information about the MPlayer-dev-eng mailing list