[MPlayer-dev-eng] [PATCH] libvo/aclib_template.c small_memcpy wrong??

[Reimar Döffinger]

Hi,
On Mon, Feb 20, 2006 at 02:52:50PM +0200, Ivan Kalvachev wrote:
> 2005/12/5, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > here is an untested patch for $SUBJECT, which I think is broken. What is
> > that dummy variable supposed to be? It is never initialized. Also
> > without cld the copy might go off in the wrong direction and cause a
> > segfault.
> 
> Read the comment, this variable is not input one, but output. This
> means that the ECX will be stored in it. The point is we don't want to
> waste time for storing it. On the other side the delta var is also
> temporal...

This does not answer the question how this is supposed to work
since ecx is not initialized...

Greetings,
Reimar Döffinger