[MPlayer-dev-eng] Re: [PATCH] More complete ASF MIME detection, closing bug# 248

[Bertrand Baudet]

Hi,

On Monday 20 February 2006 13:52, Guillaume POIRIER wrote:
> Hi,
>
> On 11/6/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> 
wrote:
> > Hi,
> >
> > On Sun, Nov 06, 2005 at 03:09:25PM +0100, Guillaume POIRIER wrote:
> > > On 11/6/05, Zuxy <zuxy.meng at gmail.com> wrote:
> > > > 2005/11/2, Zuxy <zuxy.meng at gmail.com>:
> > > > > Also consistent with asf mime types in asf_streaming.c.
> > > >
> > > > No comments?
> > >
> > > Good patch. I'll gladly apply it tonite unless someone objects.
> > > Reimar, you're listed in bugzilla as one of the few who had a look a
> > > the bug. Could you have a look at the patch too?
> >
> > Well, it might be better to fix the auto-detection of the asf
> > demuxer - especially since I really hate that mime-type stuff.
> > And I agree that at least octet-stream should not be "hardwired" to the
> > asf demuxer.
>
> What's up with this patch (re-attached)? I Roberto's and Reimar's
> comments made it look like it was okay, though more work should be
> done to improve the core code, but until then...
>
> I'm tempted to apply this patch, but unwilling to drink the cola if if
> breaks something...
>
> Would it be okay to apply it (if it still applies cleanly) to get some
> testing, and remove it if ever it messes things up?

Yes go for it!
I checked the mimetypes in asf_streaming.c and they
are already there in asf_http_streaming_type() so it shouldn't hurt.
If I recall well, a first HTTP request is made with  "MPlayer" as a user-agent
then depending on the server's user-agent, another request is redone
with "NSPlayer" to be accepted by the MS streaming server.
Then the response of the server should have one those mimetypes.
So if the mimetype is detected earlier than in the ASF_HTTP parser,
another request will be done anyway by the ASF_HTTP code and
then the mimetype redetected again.
The issue could be with the "application/octet-stream" mimetype since it
can carry anything. Hopefully the ASF_HTTP parser will stop if the payload
is not as expected.

Hope this help ;)

Bertrand