[MPlayer-dev-eng] [PATCH] dsize negative scale values

[RC]

On Sun, 3 Jul 2005 22:36:32 +0300
Oded Shimon <ods15 at ods15.dyndns.org> wrote:

> But, it's impossible to do the 'keepaspect' thing with -1 or -2:
> say I have this - I want a "bounding box" of 800x600 - which would
> work for ANY aspect, WITHOUT distorting. It's IMPOSSIBLE currently,
> and would still be impossible with your patch. 

Well, with mine: "dsize=800:-2" would keep the dimentions under 800x600
for any videos with any aspect of 4/3 (1.333...) or above.  I've never
seen any videos with an aspect below 4/3, so I'd say you're very safe.


> and with my patch you can still do anything offered in your patch:

I wish I could argue with you, but it will take me weeks to figure out
how your dsize parameters are supposed to work.  

It also seems like you didn't do much testing with your patch. 

Any time I give a value for keepaspect of 0 or 2, and only one
dimention (height OR width), it crashes (eg. dsize=400:0:2).  Then
again, maybe I just haven't figured out the parameters yet.

A value of 0 for keepaspect doesn't seem to work right either.
(eg "dsize=-1:-1:0")

> yours: dsize=800:-2
> mine:  dsize=800:0:1 // or something like that, can't remember exact
> "codes"

It's scary that you wrote it, and you can't even figure out what
parameters to use.  I've been playing around with it for the past 15
minutes, and I can't figure out what each of the parameters should do
either.  By trial, and error I've figured a few out, and even then,
I'm not sure it would still work right if used on a video with a
different aspect.