[MPlayer-dev-eng] [PATCH] dsize negative scale values

Oded Shimon ods15 at ods15.dyndns.org
Sun Jul 3 21:36:32 CEST 2005


On Sun, Jul 03, 2005 at 12:25:32PM -0700, RC wrote:
> On Sat, 2 Jul 2005 23:28:58 +0300
> Oded Shimon <ods15 at ods15.dyndns.org> wrote:
> 
> > dsize=w:h:keepaspect:round
> > 
> > for w,h, -1 means d_w/d_h, and 0 means original w/h
> > 
> > for keepaspect, 0 means nothing, 1 means force d_w/d_h aspect, by 
> > downscaling, 2 means the same, but upscaling, 3 and 4 mean the same,
> > but with w/h aspect.
> 
> I'm still not sure what you want "keepaspect" for.  Using -1
> and/ or -2 you can maintain the aspect, either upscaling or downscaling.
> 
> "round" wouldn't be difficult to adapt from vf_scale, but I can't find
> any reason it would be at all useful for dsize.

TBH, I myself have no idea what round could ever be useful for. but, it's 
easy to implement and it's... "whatever, aslong as we're adding that.. 
might as well..."

But, it's impossible to do the 'keepaspect' thing with -1 or -2:
say I have this - I want a "bounding box" of 800x600 - which would work for 
ANY aspect, WITHOUT distorting. It's IMPOSSIBLE currently, and would still 
be impossible with your patch. Possible with my patch though. and with my 
patch you can still do anything offered in your patch:

yours: dsize=800:-2
mine:  dsize=800:0:1 // or something like that, can't remember exact "codes"

Granted, it's not as "simple"... But it has the same effect.

- ods15




More information about the MPlayer-dev-eng mailing list