[MPlayer-dev-eng] [PATCH] shufle for gui playlist ENGLISH

[Rojer]

i fixed the bug that caused shuffle to stop working when the next entry 
to be played was the last entry of the playlist... oops ;)

-- 
Deomid Ryabkov aka Rojer
myself at rojer.pp.ru
rojer at sysadmins.ru

Diego Biurrun wrote:
> Rojer writes:
> 
>>Diego Biurrun wrote:
>>
>>>It does not work for me.  When I press the shuffle button nothing
>>>happens.
>>
>>Shuffle should appear as a check-item in the dropdown menu.
>>when checked, it basically makes prev/next buttons to skip to random 
>>track when pressed.
>>more precisely, there is a "window" of 16 (GUI_SHUFFLE_WINDOW_SIZE) 
>>items with current item indexed by "slider" (swi variable).
>>when the slider reaches either edge of the "window", the next item to be 
>>played is determined by either picking a random one (shuffle is checked) 
>>or the next one (shuffle unchecked).
>>this adds convenience (compared to just picking random item every time) 
>>in that you can get back to "what was that previous song played" by 
>>simply pressing prev button.
> 
> 
> It stops working after a few keypresses for me, sometimes more,
> sometimes less.
> 
> 
>>>>+   case gtkGetNextPlItem: 
>>>>+   case gtkGetPrevPlItem:
>>>
>> > This line is duplicated.  Just remove the first, it's the one with the
>> > trailing whitespace ;-)
>>
>>this is not a dupe, these are cases for Next and Prev sharing similar code.
> 
> 
> Never mind, I was just too blind to see that one is next and the other
> is prev.  Must have been one hell of a substance I was enjoying, I
> don't even remember taking it 8-)
> 
> 
>>>Please just update the English messages.
>>
>>ok, i just thought i should add it to every file so not to break the 
>>build for other languages.
> 
> 
> Did you try ;-)  Missing messages are taken from the English master
> file.
> 
> Diego
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: shuffle3.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040927/765f656e/attachment.asc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3228 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040927/765f656e/attachment.bin>