[MPlayer-dev-eng] [PATCH] shufle for gui playlist ENGLISH

Diego Biurrun diego at biurrun.de
Sun Sep 19 22:07:57 CEST 2004


Rojer writes:
> Diego Biurrun wrote:
> > 
> > It does not work for me.  When I press the shuffle button nothing
> > happens.
> 
> Shuffle should appear as a check-item in the dropdown menu.
> when checked, it basically makes prev/next buttons to skip to random 
> track when pressed.
> more precisely, there is a "window" of 16 (GUI_SHUFFLE_WINDOW_SIZE) 
> items with current item indexed by "slider" (swi variable).
> when the slider reaches either edge of the "window", the next item to be 
> played is determined by either picking a random one (shuffle is checked) 
> or the next one (shuffle unchecked).
> this adds convenience (compared to just picking random item every time) 
> in that you can get back to "what was that previous song played" by 
> simply pressing prev button.

It stops working after a few keypresses for me, sometimes more,
sometimes less.

> >>+   case gtkGetNextPlItem: 
> >>+   case gtkGetPrevPlItem:
> > 
>  > This line is duplicated.  Just remove the first, it's the one with the
>  > trailing whitespace ;-)
> 
> this is not a dupe, these are cases for Next and Prev sharing similar code.

Never mind, I was just too blind to see that one is next and the other
is prev.  Must have been one hell of a substance I was enjoying, I
don't even remember taking it 8-)

> > Please just update the English messages.
> 
> ok, i just thought i should add it to every file so not to break the 
> build for other languages.

Did you try ;-)  Missing messages are taken from the English master
file.

Diego




More information about the MPlayer-dev-eng mailing list