[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc), third patches
diego at biurrun.de
Mon Sep 13 10:16:15 CEST 2004
The Wanderer writes:
> Diego Biurrun wrote:
> > The Wanderer writes:
> >> Oops. Fatal typo in this one; corrected patch attached.
> > Please update your patches instead of sending patches to be applied
> > on top of the old ones. This makes applying and reviewing them
> > easier.
> ...? Unless I'm misunderstanding something, the only patches I've sent
> in which this is to be applied "on top of" are those which have already
> been applied. These patches were made by 'diff -Naur main/file.c
> main.working/file.c > patch.diff', with both source trees recently
> updated from current CVS.
Since my mailer shows your patches inline, I assumed it was one big
patch. This is not the case, you have split it up into four small
patches. Please do not split your patches up like this. Right now I
am in the situation that I wanted to apply your patch, but it consists
of four small pieces, three of which seem to have been revised.
Looking through my mailbox for all the right pieces is tedious and
error-prone. So please send one big patch and when you revise it,
update the whole patch. This way I just have to look through the
thread from bottom to top and grab the last patch you sent.
More information about the MPlayer-dev-eng