[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc), third patches

The Wanderer inverseparadox at comcast.net
Sat Sep 11 22:02:48 CEST 2004


Diego Biurrun wrote:

> The Wanderer writes:
> 
>> Oops. Fatal typo in this one; corrected patch attached.
> 
> Please update your patches instead of sending patches to be applied
> on top of the old ones.  This makes applying and reviewing them
> easier.

...? Unless I'm misunderstanding something, the only patches I've sent
in which this is to be applied "on top of" are those which have already
been applied. These patches were made by 'diff -Naur main/file.c
main.working/file.c > patch.diff', with both source trees recently
updated from current CVS.

The previous mencoder.c patches I submitted have been committed. They
made changes (well, a change) which should not have been made, and the
first of the preceding patches corrects that.

The previous mplayer.c patches I submitted have not been committed. They
include changes which should not be made; the second patch is an updated
version of that patch, which does not make those changes.

The third patch is the help_mp-en.h complement to the first two; its
changes are of the same nature.

The 'fourth' patch is intended to be used in place of the first, because
the first contained a typo which would break the compile. It does not
require anything in the way of prior patches which the first did not
also require.

I don't see what I could reasonably have done differently... so if
there's something I'm doing wrong here, please do be explicit about what
it is, because I honestly have no idea where to look.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.




More information about the MPlayer-dev-eng mailing list