[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc), third patches

[The Wanderer]

Diego Biurrun wrote:

> The Wanderer writes:
> 
>> Diego Biurrun wrote:

>>> Please update your patches instead of sending patches to be
>>> applied on top of the old ones.  This makes applying and
>>> reviewing them easier.
>> 
>> ...? Unless I'm misunderstanding something, the only patches I've
>> sent in which this is to be applied "on top of" are those which
>> have already been applied. These patches were made by 'diff -Naur
>> main/file.c main.working/file.c > patch.diff', with both source
>> trees recently updated from current CVS.
> 
> Since my mailer shows your patches inline, I assumed it was one big
> patch.  This is not the case, you have split it up into four small
> patches.

Actually I was doing this intentionally, because A) I've seen
several/many others do it the same way, B) that seems most of the time
to be how they're committed (multiple CVS-log messages with the same
description but one file per message, rather than many files and just
one message), and C) it makes it much easier for me to re-create the
patch if some part of it (say, just one file's worth) needs to be
changed; rather than having to

diff -u main/file1.c main.working/file1.c > patch.diff && diff -u 
main/file2.c main.working/file2.c >> patch.diff && (...)

I'd just need to re-diff the single file.

I can certainly do it otherwise if that truly is appropriate, but it's
more work than I'd thought from observation was really necessary...

> Please do not split your patches up like this.  Right now I am in the
> situation that I wanted to apply your patch, but it consists of four
> small pieces, three of which seem to have been revised.

Two, actually, but the point is acknowledged.

> Looking through my mailbox for all the right pieces is tedious and
> error-prone.  So please send one big patch and when you revise it,
> update the whole patch.  This way I just have to look through the
> thread from bottom to top and grab the last patch you sent.

Would be attached, but conflicts with the EDL patch just submitted by
Reynaldo Pinochet, so rather than have to re-make and re-send yet again
I'll wait until his has been either committed or rejected.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.