[MPlayer-dev-eng] Release... How about it?

[Reimar Döffinger]

Hi,
> RD>I'd really like to have a release soon, there were so many bug fixed
> RD>that I think it would be quite worth it for any user that fears CVS.
> RD>And more importantly, so many features were added, we really need that
> RD>additional checking IMHO...
> 
> Please consider my post to mplayer-users list (sigh.. unfortunately,
> bugreports are still read only if they are posted directly to
> mplayer-dev list). I can't send the patch because I don't have this

Wrong. It sure was read, and I even discussed it with beastd (I don't
know if I referred specifically to this mail, but still...).

> code, maybe someone kept the original patch and can send it again so it
> can be reversed?

This patch did not cause the bug, actually just several bugs were hiding
behind this one...

Please try the attached patch, I can't see any point in using a pipe for
buffering keyboard input anyway...

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: fifo.c
===================================================================
RCS file: /cvsroot/mplayer/main/fifo.c,v
retrieving revision 1.6
diff -u -r1.6 fifo.c
--- fifo.c	5 Nov 2004 04:13:25 -0000	1.6
+++ fifo.c	17 Nov 2004 19:23:50 -0000
@@ -1,5 +1,5 @@
 
-#ifndef HAVE_NO_POSIX_SELECT
+#if 0
 
 // keyboard:
 static int keyb_fifo_put=-1;
@@ -34,7 +34,7 @@
 
 #else
 
-#define KEY_FIFO_SIZE 1024
+#define KEY_FIFO_SIZE 20
 static int key_fifo_data[KEY_FIFO_SIZE];
 static int key_fifo_read=0;
 static int key_fifo_write=0;
Index: mplayer.c
===================================================================
RCS file: /cvsroot/mplayer/main/mplayer.c,v
retrieving revision 1.812
diff -u -r1.812 mplayer.c
--- mplayer.c	15 Nov 2004 15:29:39 -0000	1.812
+++ mplayer.c	17 Nov 2004 19:24:02 -0000
@@ -1307,7 +1307,7 @@
 // Init input system
 current_module = "init_input";
 mp_input_init();
-#ifndef HAVE_NO_POSIX_SELECT
+#if 0
 make_pipe(&keyb_fifo_get,&keyb_fifo_put);
 
 if(keyb_fifo_get > 0)