[MPlayer-dev-eng] [PATCH] segfault at v4l2 uninit

Aurelien Jacobs aurel at gnuage.org
Tue Dec 21 23:34:08 CET 2004


Hi,

I've just found a bug in the v4l2 code.
When watching tv and then switching to a new stream
(with the loadfile slave command for example), v4l2
segfault at uninit. This is due to the tv_param_noaudio
var being reseted by m_config_pop before the v4l2 uninit.
This cause uninit to try to pthread_join when no thread
were created.

The patch fix the issue in a very simple way (making sure
the thread was really created before trying to join).
It may be better to uninit before the m_config_pop but
this would involves more important changes, so I think
this trivial fix is a better solution in the meantime.
I think it should be applied before pre6 release, so if
noboby is against it, I will apply quickly.

Aurel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: v4l2-fix.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041221/4a7145e5/attachment.txt>


More information about the MPlayer-dev-eng mailing list