[MPlayer-dev-eng] [PATCH] segfault at v4l2 uninit

Aurelien Jacobs aurel at gnuage.org
Wed Dec 22 14:18:56 CET 2004


On Tue, 21 Dec 2004 23:34:08 +0100
Aurelien Jacobs <aurel at gnuage.org> wrote:

> Hi,
> 
> I've just found a bug in the v4l2 code.
> When watching tv and then switching to a new stream
> (with the loadfile slave command for example), v4l2
> segfault at uninit. This is due to the tv_param_noaudio
> var being reseted by m_config_pop before the v4l2 uninit.
> This cause uninit to try to pthread_join when no thread
> were created.
> 
> The patch fix the issue in a very simple way (making sure
> the thread was really created before trying to join).
> It may be better to uninit before the m_config_pop but
> this would involves more important changes, so I think
> this trivial fix is a better solution in the meantime.
> I think it should be applied before pre6 release, so if
> noboby is against it, I will apply quickly.

As it's very simple and it fixes a segfault, I just applied it.

Aurel




More information about the MPlayer-dev-eng mailing list