[MPlayer-dev-eng] GTF + vesa patch

[Felix Buenemann]

On Wednesday 14 August 2002 15:02, Rudolf Marek wrote:
> After a long time I had time and I implemented the General Timing
> Formula algorithm from a scratch. I modified also vo_vesa.c so iit now
> adjust the timing to highest possible refresh rate using the monitor
> capabilities from a config file.
>
> I dont know if the attachment of parametrs into vo_vesa.c is good so.
> Please let me know if anything is wrong.
You should cleanup your code a bit, this is what I noticed:
 - the GTF_constants struct contains DOS linewraps
 - if you have multiple possibility code, do not override the previous 
definition, but instead use sth. like:
#if defined(XY)
#define blah() blub()
#else
#define blah()
#endif
to omit compiler warnings.
 - cleanup the shared vars of fbdev and vesa, now it is pretty ugly, instead 
move those vars to libvo/video_out.c and reference them as extern from fbdev 
and vesa.

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________