[MPlayer-cvslog] r29290 - trunk/xvid_vbr.c

[Diego Biurrun]

On Tue, May 12, 2009 at 01:31:59PM -0400, Reynaldo H. Verdejo Pinochet wrote:
> 
> Reimar Döffinger wrote:
> > 
> > Because it "SPAMs" the commit mailing list, as well as the commit log
> > (several consecutive messages that say the same thing is not really helpful).
> > For anyone paranoid, it is also a bit more effort to verify that the commits
> > are whitespace-only changes (only minimally more as long as there are not
> > other commits in-between I admit).
> > Also generally closely related stuff is expected to be committed together, not
> > split per file.
> 
> You both seem to miss the point about these messages being a voluntary
> , self-imposed consequence to the commiting action. From where I'm
> standing it made sense to do it per file as I wasn't targeting any given
> set of them. They just naturally followed each other as I had some
> spare time left, at some point I stopped an that was it, I didn't plan
> to do 8 files in a row. That been said I don't really think in
> post-commit hooks while commiting but in the change itself. and the
> change made sense. Now, I'm wondering if this means the only way to
> do this correctly is all at once.

You did this by hand instead of mechanically?

> Would that apply for all changes you deem trivial?

Trivial but similar changes are best grouped together, yes.

Diego