[MPlayer-cvslog] r29290 - trunk/xvid_vbr.c

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Tue May 12 19:31:59 CEST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello

Reimar Döffinger wrote:
> 
> Because it "SPAMs" the commit mailing list, as well as the commit log
> (several consecutive messages that say the same thing is not really helpful).
> For anyone paranoid, it is also a bit more effort to verify that the commits
> are whitespace-only changes (only minimally more as long as there are not
> other commits in-between I admit).
> Also generally closely related stuff is expected to be committed together, not
> split per file.

You both seem to miss the point about these messages being a voluntary
, self-imposed consequence to the commiting action. From where I'm
standing it made sense to do it per file as I wasn't targeting any given
set of them. They just naturally followed each other as I had some
spare time left, at some point I stopped an that was it, I didn't plan
to do 8 files in a row. That been said I don't really think in
post-commit hooks while commiting but in the change itself. and the
change made sense. Now, I'm wondering if this means the only way to
do this correctly is all at once. Would that apply for all changes
you deem trivial? Considering the size of our trunk and the amount
of floating trivialities I don't see how this would benefit anyone.

Anyway, I'm taking your advice for future changes, I remain
doubtful about its merit though.

Bests

- --
Reynaldo H. Verdejo Pinochet
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoJso4ACgkQwY4HfzEURSoo2ACdHZoM0Kl3Io8GQ9FFU/yZ7+YU
+2MAnRBFQDhuJnvNEKvOp2oK8K0cjb5T
=M9nK
-----END PGP SIGNATURE-----


More information about the MPlayer-cvslog mailing list