[MPlayer-cvslog] r29290 - trunk/xvid_vbr.c

[Uoti Urpala]

On Tue, 2009-05-12 at 13:31 -0400, Reynaldo H. Verdejo Pinochet wrote:
> Reimar Döffinger wrote:
> > 
> > Because it "SPAMs" the commit mailing list, as well as the commit log
> > (several consecutive messages that say the same thing is not really helpful).

> You both seem to miss the point about these messages being a voluntary
> , self-imposed consequence to the commiting action. From where I'm
> standing it made sense to do it per file as I wasn't targeting any given
> set of them. They just naturally followed each other as I had some

You did much more harm than good. If you can't see that, consider all
the files in MPlayer. There are about 1000 .c and .h files in the tree.
Now, removing trailing whitespace in all the files would give at most a
minor _total_ benefit, whereas having 1000 extra commits would cause
major harm.

If you're doing useful work on a file and are bothered by trailing
whitespace then it could be OK to remove it as part of other changes.
But removing trailing whitespace from one random file for no special
reason is not normally worth a commit.