[MPlayer-cvslog] r22607 - trunk/mp3lib/Makefile

[Guillaume Poirier]

Hi,

diego wrote:
> Author: diego
> Date: Thu Mar 15 13:17:22 2007
> New Revision: 22607
> 
> Modified:
>    trunk/mp3lib/Makefile
> 
> Log:
> Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
> 
> 
> Modified: trunk/mp3lib/Makefile
> ==============================================================================
> --- trunk/mp3lib/Makefile	(original)
> +++ trunk/mp3lib/Makefile	Thu Mar 15 13:17:22 2007
> @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes)
>  SRCS_COMMON += dct64_altivec.c
>  ifeq ($(TARGET_OS),Darwin)
>  CFLAGS += -faltivec
> -else
> -CFLAGS += -maltivec -mabi=altivec

Are you sure this is a good idea? From what I'm seeing, you are tying
to have CFLAGS always contain -maltivec if the processor supports it.
Correct me if I'm wrong, but that is likely to break runtime CPU
detection for ppl who build on G4 for G3 machines, as -maltivec allows
the compiler to generate Altivec code whenever it feels like it (not
just when it's fed with Altivec intrinsics).

x264 had that problem and it's been fixed yesterday.
In case you're interested, here's the diff:
http://trac.videolan.org/x264/changeset/629
(there were other follow-up commits after this one as it broke other
stuff, you can follow the discussions here:
http://www.via.ecp.fr/via/ml/x264-devel/2007-03/index.html )

Guillaume