[MPlayer-cvslog] r22607 - trunk/mp3lib/Makefile

[Diego Biurrun]

On Thu, Mar 15, 2007 at 02:49:45PM +0100, Guillaume Poirier wrote:
> 
> diego wrote:
> > 
> > Log:
> > Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
> > 
> > --- trunk/mp3lib/Makefile	(original)
> > +++ trunk/mp3lib/Makefile	Thu Mar 15 13:17:22 2007
> > @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes)
> >  ifeq ($(TARGET_OS),Darwin)
> >  CFLAGS += -faltivec
> > -else
> > -CFLAGS += -maltivec -mabi=altivec
> 
> Are you sure this is a good idea? From what I'm seeing, you are tying
> to have CFLAGS always contain -maltivec if the processor supports it.

No, I just don't want to have wild and unnecessary setting of CFLAGS in
random Makefiles.  It's configure's job and in this case, configure is
already setting those flags.  Whether it is wrong or right to do this is
another issue.  But if it is wrong, then it is even more fatal to
override configure in the Makefile...

Diego