[MPlayer-cvslog] r22607 - trunk/mp3lib/Makefile

[Guillaume POIRIER]

Hi,

On 3/15/07, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Mar 15, 2007 at 01:36:32PM +0100, Reimar D?ffinger wrote:
> > On Thu, Mar 15, 2007 at 01:17:22PM +0100, diego wrote:
> > >
> > > Modified:
> > >    trunk/mp3lib/Makefile
> > >
> > > Log:
> > > Remove addition of AltiVec flags to CFLAGS, configure takes care of this.
> > >
> > > --- trunk/mp3lib/Makefile   (original)
> > > +++ trunk/mp3lib/Makefile   Thu Mar 15 13:17:22 2007
> > > @@ -18,8 +18,6 @@ ifeq ($(TARGET_ALTIVEC),yes)
> > >  SRCS_COMMON += dct64_altivec.c
> > >  ifeq ($(TARGET_OS),Darwin)
> > >  CFLAGS += -faltivec
> > > -else
> > > -CFLAGS += -maltivec -mabi=altivec
> > >  endif
> > >  endif
> >
> > Why is only half of it removed? Comparing with ffmpeg configure, the
> > -faltivec is for Apple and -maltivec -mabi=altivec is for vanilla gcc,
> > so it should depends on gcc version which one is done, not on OS
> > anyway...
>
> I was planning to remove it (and have just done so), but I wanted to
> reboot into OS X to doublecheck first.

I just tested on 10.3.x and it works fine without it. You can safely
remove it I guess.

Guilaume