[Mndiff-dev] [PATCH] mndiff (er, mnzip): alternative stream usage patch

Corey Hickey bugfood-ml at fatooh.org
Wed Jun 20 19:03:57 CEST 2007


Michael Niedermayer wrote:
> Hi
> 
> On Tue, Jun 19, 2007 at 05:38:21PM -0700, Corey Hickey wrote:
> [...]
>>>>     int low_mem= 0;
>>>>     int block_size= 1<<22;
>>>>     int outsize, i;
>>>>     static const uint8_t header[7]={'M','N','Z','I','P',0,0};
>>>>
>>>> -    if (argc != 3)
>>>> -        help();
>>>> -
>>>> -    for(i=0; argv[1][i]; i++){
>>>> +    for(i=0; argv[1] && argv[1][i]; i++){
>>> shouldnt we rather check argc instead of argv[1]?
>> If you prefer; that's just how it was before.
>>
>> If you like this patch, I'll send a cosmetic patch afterward.
> 
> applied

Thanks.

-Corey



More information about the Mndiff-dev mailing list