[Mndiff-dev] [PATCH] mndiff (er, mnzip): alternative stream usage patch

[Michael Niedermayer]

Hi

On Tue, Jun 19, 2007 at 05:38:21PM -0700, Corey Hickey wrote:
[...]
> >
> >>     int low_mem= 0;
> >>     int block_size= 1<<22;
> >>     int outsize, i;
> >>     static const uint8_t header[7]={'M','N','Z','I','P',0,0};
> >> 
> >>-    if (argc != 3)
> >>-        help();
> >>-
> >>-    for(i=0; argv[1][i]; i++){
> >>+    for(i=0; argv[1] && argv[1][i]; i++){
> >
> >shouldnt we rather check argc instead of argv[1]?
> 
> If you prefer; that's just how it was before.
> 
> If you like this patch, I'll send a cosmetic patch afterward.

applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mndiff-dev/attachments/20070620/563c5e89/attachment.pgp>