[FFmpeg-devel] [PATCH 12/13] Extend documentation for parse_filter().

Stefano Sabatini stefano.sabatini-lala
Sat Nov 6 13:38:46 CET 2010


On date Saturday 2010-11-06 02:44:09 +0100, Michael Niedermayer encoded:
> On Sat, Nov 06, 2010 at 02:25:13AM +0100, Stefano Sabatini wrote:
> > ---
> >  libavfilter/graphparser.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> > 
> > diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c
> > index 42e93de..ba4b0de 100644
> > --- a/libavfilter/graphparser.c
> > +++ b/libavfilter/graphparser.c
> > @@ -144,7 +144,12 @@ static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int ind
> >  }
> >  
> >  /**
> > - * Parse "filter=params"
> > + * Parse a string of the type FILTER_NAME[=PARAMS], and create a
> 
> of the form
> 
> 
> > + * corresponding filter which is added to graph.
> 
> create and filter is ambigous
> 
> 
> 
> > + *
> > + * @param index an index which is associated to the filter instance in
> > + * the graph
> 
> that tells us nothing, what value shoudl be used always 0?
> dox should be there so someone can use the code without reading the source of
> the implementation.
> your doxy does not achive this at all

New try attached.
-- 
FFmpeg = Fiendish and Fast Mega Powerful Erratic God



More information about the ffmpeg-devel mailing list