[FFmpeg-devel] [PATCH 12/13] Extend documentation for parse_filter().

[Michael Niedermayer]

On Sat, Nov 06, 2010 at 01:38:46PM +0100, Stefano Sabatini wrote:
> On date Saturday 2010-11-06 02:44:09 +0100, Michael Niedermayer encoded:
> > On Sat, Nov 06, 2010 at 02:25:13AM +0100, Stefano Sabatini wrote:
> > > ---
> > >  libavfilter/graphparser.c |    7 ++++++-
> > >  1 files changed, 6 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c
> > > index 42e93de..ba4b0de 100644
> > > --- a/libavfilter/graphparser.c
> > > +++ b/libavfilter/graphparser.c
> > > @@ -144,7 +144,12 @@ static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int ind
> > >  }
> > >  
> > >  /**
> > > - * Parse "filter=params"
> > > + * Parse a string of the type FILTER_NAME[=PARAMS], and create a
> > 
> > of the form
> > 
> > 
> > > + * corresponding filter which is added to graph.
> > 
> > create and filter is ambigous
> > 
> > 
> > 
> > > + *
> > > + * @param index an index which is associated to the filter instance in
> > > + * the graph
> > 
> > that tells us nothing, what value shoudl be used always 0?
> > dox should be there so someone can use the code without reading the source of
> > the implementation.
> > your doxy does not achive this at all
> 
> New try attached.
> -- 
> FFmpeg = Fiendish and Fast Mega Powerful Erratic God

>  graphparser.c |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> ab9fe40ca28ec1df264946b38b788376d00be4da  0011-Extend-documentation-for-parse_filter.patch
> From b5a03e34d89f3769b43637620e7d18aae3f23169 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 6 Nov 2010 02:09:28 +0100
> Subject: [PATCH 11/13] Extend documentation for parse_filter().
> 
> ---
>  libavfilter/graphparser.c |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c
> index 89daa96..a2b765d 100644
> --- a/libavfilter/graphparser.c
> +++ b/libavfilter/graphparser.c
> @@ -139,7 +139,18 @@ static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int ind
>  }
>  
>  /**
> - * Parse "filter=params"
> + * Parse a string of the form FILTER_NAME[=PARAMS], and create a
> + * corresponding filter instance which is added to graph.
> + *

> + * @param filt_ctx put here a pointer to the created filter context in
> + * case of success, NULL otherwise.

some native englishman should look at this, its rather hard to read

otherwise your patch looks alot better than before and i have no further
comments

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101106/4b75c343/attachment.pgp>