[FFmpeg-devel] [PATCH 12/13] Extend documentation for parse_filter().

[Michael Niedermayer]

On Sat, Nov 06, 2010 at 02:25:13AM +0100, Stefano Sabatini wrote:
> ---
>  libavfilter/graphparser.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c
> index 42e93de..ba4b0de 100644
> --- a/libavfilter/graphparser.c
> +++ b/libavfilter/graphparser.c
> @@ -144,7 +144,12 @@ static int create_filter(AVFilterContext **filt_ctx, AVFilterGraph *ctx, int ind
>  }
>  
>  /**
> - * Parse "filter=params"
> + * Parse a string of the type FILTER_NAME[=PARAMS], and create a

of the form


> + * corresponding filter which is added to graph.

create and filter is ambigous



> + *
> + * @param index an index which is associated to the filter instance in
> + * the graph

that tells us nothing, what value shoudl be used always 0?
dox should be there so someone can use the code without reading the source of
the implementation.
your doxy does not achive this at all

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101106/1dbcd34f/attachment.pgp>