[FFmpeg-devel] [PATCH] Electronic Arts TGV decoder

Reimar Döffinger Reimar.Doeffinger
Fri Aug 1 19:33:13 CEST 2008


Hello,
On Wed, Jul 30, 2008 at 07:50:26PM +1000, pross at xvid.org wrote:
> On Wed, Jul 30, 2008 at 06:45:11AM +0200, Reimar D?ffinger wrote:
> > Ok by me, though I did not test my lzo patch myself, and it would be
> > nice if you could do a quick benchmark with lzo.c compiled with -DTEST
> > to make sure it does not slow things down (too much).
> > Otherwise it might be better to make an additional function that is
> > forced to be inlined and call that from both the exported and the
> > internal one.
> 
> The patch works, but gives 7-10% slow-down in the lzo test. Inline version
> enclosed.

I was actually thinking to keep stuff in lzo.c, thus only inlining the
code for the lzo decoder while having noninlined external code.
I do not mind much anyway, esp. if you think the performance matters for
your code, too.
IMO go ahead if nobody objects.

Greetings,
Reimar D?ffinger

P.S.: I probably won't have any internet at least until Monday, possibly
longer, just in case you wonder why I "disappeared"...




More information about the ffmpeg-devel mailing list