[FFmpeg-devel] [PATCH] mmx implementation of vc-1 inverse transformations
Tue Aug 26 03:59:26 CEST 2008
On Tue, Aug 26, 2008 at 03:46:24AM +0200, Michael Niedermayer wrote:
> On Tue, Aug 26, 2008 at 02:05:49AM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > > Also the 8x8 transform either has to be optimal or removed from the patch.
> > How do you know when something is optimal?
> I do not, but when i find something suboptimal then i know it is not.
> So taken litterally i surely have not said it well at all ...
> somewhat better would have been saying:
> It must not contain any suboptimality that will be found in a review,
> and of course it should not contain any known suboptimalities even if
> we miss such suboptimalities.
> And even better would be to limit that to suboptimalities that can be
> fixed in reality (that is not just ones we could proof to exist but ones
> that could be fixed by a finite number of known/calculateable steps).
> Iam not sure if i have missed any further holes, but i hope not :)
Of course it contains holes :(
It must not contain any suboptimality that will be found in a review
and that we belive can be corrected by a good developer within his lifespan.
Also out of nettiquete one should not submit patches that one knows
contain such suboptimalities.
... hmm strange ... where did all the people with pitchforks, torches and
ice picks came from all of a sudden
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have often repented speaking, but never of holding my tongue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel