[FFmpeg-devel] [PATCH] Electronic Arts TGV decoder

pross at xvid.org pross
Sun Aug 3 14:43:26 CEST 2008

On Fri, Aug 01, 2008 at 07:33:13PM +0200, Reimar D?ffinger wrote:
> Hello,
> On Wed, Jul 30, 2008 at 07:50:26PM +1000, pross at xvid.org wrote:
> > On Wed, Jul 30, 2008 at 06:45:11AM +0200, Reimar D?ffinger wrote:
> > > Ok by me, though I did not test my lzo patch myself, and it would be
> > > nice if you could do a quick benchmark with lzo.c compiled with -DTEST
> > > to make sure it does not slow things down (too much).
> > > Otherwise it might be better to make an additional function that is
> > > forced to be inlined and call that from both the exported and the
> > > internal one.
> > 
> > The patch works, but gives 7-10% slow-down in the lzo test. Inline version
> > enclosed.
> I was actually thinking to keep stuff in lzo.c, thus only inlining the
> code for the lzo decoder while having noninlined external code.
> I do not mind much anyway, esp. if you think the performance matters for
> your code, too.
> IMO go ahead if nobody objects.

Right... performance is not a huge concern as TGV is already very fast.
(the codec was intended for 386/486 class cpus). So I have modified the
patch, again, to inline for the lzo decompressor only. 

If noone objects i will commit in ~two days time.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: memcpy_back_inline_tooeasy.diff
Type: text/x-diff
Size: 1977 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/823e5781/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/823e5781/attachment.pgp>

More information about the ffmpeg-devel mailing list