[FFmpeg-devel] [PATCH/v3.1] rmdec.c/rm.h changes to allow rtsp

Alex Beregszaszi alex
Sun Jul 22 17:13:59 CEST 2007


> > maybe you want to merge get_str() and get_str8()
> > a 1 line difference doesnt merit having a second function ...
> Makes sense. How about $attached?
> (I can also make get_str{.8}() macros to get_str_i() to save another 2x3
> lines for their function declarations, I think you originally intended that,
> but then the if(len_size==1) would no longer be inlined, making it slightly
> slower...)

I would change to get_str8 and get_str16 (make them a macro) and call
the real function get_str. What about moving this into aviobuf.c ?


More information about the ffmpeg-devel mailing list