[FFmpeg-devel] [PATCH/v3.1] rmdec.c/rm.h changes to allow rtsp

[Ronald S. Bultje]

Hi,

On 7/21/07, Michael Niedermayer <michaelni at gmx.at> wrote:
>
> On Sat, Jul 21, 2007 at 04:00:04PM -0400, Ronald S. Bultje wrote:
> > following Michael's comments, here's 4 patches (v3.1-4) for rm.h
> /rmdec.c.
> >
> > The first one fixes get_str/get_str8() to also work if the target string
> is
> > not long enough to fit all data from the container string, and allows
> NULL
> > as a string also to simply skip the string alltogether.
>
> patch ok
> btw, as you are already working with the code ...
> maybe you want to merge get_str() and get_str8()
> a 1 line difference doesnt merit having a second function ...


Makes sense. How about $attached?

(I can also make get_str{.8}() macros to get_str_i() to save another 2x3
lines for their function declarations, I think you originally intended that,
but then the if(len_size==1) would no longer be inlined, making it slightly
slower...)

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmdec-fixgetstr.patch
Type: application/octet-stream
Size: 1355 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070721/6ae4a5ed/attachment.obj>