[FFmpeg-devel] [PATCH/v3.1] rmdec.c/rm.h changes to allow rtsp

Ronald S. Bultje rsbultje
Sun Jul 22 18:38:16 CEST 2007


On 7/22/07, Alex Beregszaszi <alex at rtfs.hu> wrote:
> > > maybe you want to merge get_str() and get_str8()
> > > a 1 line difference doesnt merit having a second function ...
> >
> > Makes sense. How about $attached?
> >
> > (I can also make get_str{.8}() macros to get_str_i() to save another 2x3
> > lines for their function declarations, I think you originally intended
> that,
> > but then the if(len_size==1) would no longer be inlined, making it
> slightly
> > slower...)
> I would change to get_str8 and get_str16 (make them a macro) and call
> the real function get_str.

$attached, looks equally fine to me.

What about moving this into aviobuf.c ?

Alongside get_strz()? I guess that'd replace amf_get_string() in
flvdec.c(same as get_str16()), so possibly a good idea. You could also
add a
get_strl() (get_str16/8 could actually use this, i.e. just parse len and
then call get_strl()) and get_strv() (same, but var-len length field) to
replace the nutdec.c and nut.c (???) get_str(). Not sure how this would work
w.r.t. text encoding (ascii vs utf8 vs ???)...

Then there's also id3v1_get_string() which reads from a buf instead of
byteioctx, and get_str16_nolen in asf.c which reads 16-bit unicode
strings... But I really just want to get my rmdec-code in so I can submit
the rtsp/rdt code. :-].

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmdec-fixgetstr.patch
Type: application/octet-stream
Size: 1995 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070722/cd1bb225/attachment.obj>

More information about the ffmpeg-devel mailing list