[Ffmpeg-devel] moving non-SIMD parts of libswscale to LGPL

Michael Niedermayer michaelni
Tue Dec 19 17:06:24 CET 2006


Hi

On Tue, Dec 19, 2006 at 02:20:29PM +0100, Luca Abeni wrote:
> On Fri, 2006-12-15 at 18:05 +0100, Michael Niedermayer wrote:
> [...]
> > > > doxygen ...
> > > [...]
> > > Ok; I hope I addressed all the issues. The new version of the is
> > > attached; I post it again so that everyone can have a look, and someone
> > 
> > iam still ok with the patch (assuming it work / looks correct) ...
> I tried some conversions (such as yuv420p <--> bgr24) with ffmpeg, and
> they seemed to work ok, and I verified that swscale-example does not
> crash.
> 
> Can I commit yuv2rgb_init.c (together with the patch I previously
> posted), so that it can have more testing?

ok


> Some notes:
> - this version of the patch should not change anything if CONFIG_GPL is
> used (if it changes something, it's a bug). So, it should not break
> mplayer. After it's committed, I propose to wait for a week or two, and
> then change the code to always use yuv2rgb_init.c even if CONFIG_GPL is
> used (to remove code / data duplication)

ok


> - the code still contains the first yuv ---> rgb tables I generated. I
> plan to update them after the code is in the repository... Is this ok?

ok if regression tests pass

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle




More information about the ffmpeg-devel mailing list