[DVDnav-discuss] Patch from the Living dead for dvdnav

[Jean-Baptiste Kempf]

On Wed, Nov 02, 2011 at 04:36:55PM -0700, Erik Hovland wrote :
> > I am super-annoyed, since I have a patch on dvdnav, that I apply on all
> > VLC release, on Windows and Mac OS X, since (at least 2006).
> 
> Are you saying you only apply this patch to Windows and
> Mac OS X builds of VLC?

Yes, because I don't build for other platforms, that have a correct
package-manager.

> > I understand absolutely nothing of this obscure patch on this obscure
> > piece of code...
> 
> Obscure is right. Only constants are used and the values do not seem
> to follow a pattern.

I didn't say "piece of crap" patch, but I wasn't far.

> > I thought I should share it, with you, upstream, as someone could make
> > some sense out of it.
> 
> If you submitted the same patch but w/ the different OS #ifdefs it might
> be accepted. But otherwise, this thing is a mess.

Ok


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device