[DVDnav-discuss] Patch from the Living dead for dvdnav

[John Stebbins]

On 11/02/2011 04:30 PM, Jean-Baptiste Kempf wrote:
> Hello,
>
> I am super-annoyed, since I have a patch on dvdnav, that I apply on all
> VLC release, on Windows and Mac OS X, since (at least 2006).
>
> I understand absolutely nothing of this obscure patch on this obscure
> piece of code...
>
> It does work quite, but I can't explain it, since it predates my work on
> the project.
>
> I thought I should share it, with you, upstream, as someone could make
> some sense out of it.
>
> With my best (sorry) regards
>
>
Am I reading this cross-eyed or is this just totally stupid?

       off = lseek( fd, 32 * (off_t) DVD_VIDEO_LB_LEN, SEEK_SET );
-      if( off == ( 32 * (off_t) DVD_VIDEO_LB_LEN ) ) {
+      if (off == 16) {

unless lseek errors, off should always == 32 * DVD_VIDEO_LB_LEN and that new test should never succeed.

-- 
John      GnuPG fingerprint: D0EC B3DB C372 D1F1 0B01  83F0 49F1 D7B2 60D4 D0F7


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20111102/0688f216/attachment.asc>