[DVDnav-discuss] please review: DVDFileStat, close dev on error, use parens and BSD porting bits

[Nico Sabbi]

Il lunedì 31 agosto 2009 18:05:04 Erik Hovland ha scritto:
> I hate to bother, but could you be more specific? Does it mean
> you prefer 'if(x)' over if( x )? The empty line I get.

Indeed

>;
>
>    if( dvd_file ) {
> -    if( dvd_file->dvd->isImageFile ) {
> -      ;
> -    } else {
> +    if( !dvd_file->dvd->isImageFile ) {

for example the above line reads much better to me as:

 if(!dvd_file->dvd->isImageFile) {
...
}