[DVDnav-discuss] please review: DVDFileStat, close dev on error, use parens and BSD porting bits

[Erik Hovland]

> Il lunedì 31 agosto 2009 18:05:04 Erik Hovland ha scritto:
>> I hate to bother, but could you be more specific? Does it mean
>> you prefer 'if(x)' over if( x )? The empty line I get.
>
> Indeed
>
>>;
>>
>>    if( dvd_file ) {
>> -    if( dvd_file->dvd->isImageFile ) {
>> -      ;
>> -    } else {
>> +    if( !dvd_file->dvd->isImageFile ) {
>
> for example the above line reads much better to me as:
>
>  if(!dvd_file->dvd->isImageFile) {
> ...
> }

I definitely agree w/ this style change. But it is inconsistent w/
the rest of the file. I would prefer to be consistent w/ the file on
the commit of new code and then change the style in another
commit. Is that reasonable?

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/